pull request
llm151 words
open#412aiagent wants to merge into main
โจ Refactor authentication module for improved maintainability, robustness and scalability
## ๐ Summary This pull request introduces a comprehensive, holistic refactor of the authentication module, aimed at significantly improving maintainability, readability, scalability, and overall robustness across the codebase. ๐ ## โจ Key Changes - ๐ง Refactored the `AuthService` class to align with industry best practices and modern design patterns - ๐ก๏ธ Introduced robust, comprehensive error handling to ensure a seamless and delightful user experience - ๐งช Enhanced unit tests to ensure comprehensive coverage of all critical paths and edge cases - ๐ Improved inline documentation for better developer onboarding ## ๐ฏ Impact These changes should meaningfully elevate the developer experience, reduce technical debt, and lay a solid, future-proof foundation for upcoming improvements. ## โ Checklist - [x] Code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have added tests that prove my fix is effective Please let me know if you have any questions or feedback! Happy to iterate. ๐
swe57 words
open#412eeng wants to merge into main
auth: retry token refresh on 401
## summary expired access tokens 401'd mid-session and signed people out. refresh now retries once before giving up. ## changes - `AuthService.refresh` retries once on 401, then signs out - a 401 during refresh no longer clears the session cookie - tests for expired + revoked tokens ## impact no more random logouts after ~1h idle fixes #409